Skip to content

Conversation

@gibfahn
Copy link
Contributor

@gibfahn gibfahn commented Jul 15, 2020

Allows a hermetic xz binary to be provided.

Worth noting that busybox provides a fully static musl busybox that
should work on any Linux system, that gives you both gzip and xz.


852a84b feat(toolchain): add xz_target for remote execution

Copied what is currently done for gzip_target.


3a8f98c chore: fix typo explcitly -> explicitly


@gibfahn
Copy link
Contributor Author

gibfahn commented Jul 15, 2020

/assign @alex1545

I believe the bot wants me to do this.

@gibfahn
Copy link
Contributor Author

gibfahn commented Sep 21, 2020

Looks like head has changed to using Go for gzip (#1613), is there a plan to do the same for xz, or is this PR the best bet for a way forward?

@smukherj1 would you mind taking a look?

@gibfahn
Copy link
Contributor Author

gibfahn commented Sep 21, 2020

/assign @smukherj1

Copied what is currently done for gzip_target.
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gibfahn
To complete the pull request process, please assign smukherj1 after the PR has been reviewed.
You can assign the PR to them by writing /assign @smukherj1 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pcj
Copy link
Member

pcj commented May 22, 2021

Closing due to age.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants