Skip to content

Move Apple toolchain setup to apple_support#154

Merged
copybara-service[bot] merged 2 commits intobazelbuild:mainfrom
keith:ks/move-apple-toolchain-setup-to-apple_support
Jan 18, 2023
Merged

Move Apple toolchain setup to apple_support#154
copybara-service[bot] merged 2 commits intobazelbuild:mainfrom
keith:ks/move-apple-toolchain-setup-to-apple_support

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Nov 1, 2022

@keith keith force-pushed the ks/move-apple-toolchain-setup-to-apple_support branch from af5894a to d0d19a7 Compare November 3, 2022 18:06
@keith keith marked this pull request as ready for review December 13, 2022 04:04
oquenchil
oquenchil previously approved these changes Dec 13, 2022
@keith keith force-pushed the ks/move-apple-toolchain-setup-to-apple_support branch from d0d19a7 to ffaaf6b Compare January 9, 2023 17:05
@keith
Copy link
Copy Markdown
Member Author

keith commented Jan 9, 2023

I think some of the other open PRs removing duplication in this repo will have to land first for this now, something must have changed upstream

keith added 2 commits January 10, 2023 08:43
This defaults to C++, and the previous setup will be moved to
apple_support
@keith keith force-pushed the ks/move-apple-toolchain-setup-to-apple_support branch from ffaaf6b to 404bb43 Compare January 10, 2023 16:43
@keith
Copy link
Copy Markdown
Member Author

keith commented Jan 10, 2023

Merging #163 instead would be ideal, but if that one is blocked for some reason doing this one in the meantime would be fine

@oquenchil
Copy link
Copy Markdown
Contributor

Hey Keith,

No blockers for now on merging the rest, right now it's just pending reviews internally. I will get all of those merged first.

@oquenchil
Copy link
Copy Markdown
Contributor

And thank you!

@keith
Copy link
Copy Markdown
Member Author

keith commented Jan 11, 2023

Awesome thanks! Can you create a new release somewhere in there so we can update what is in bazel?

@keith keith closed this Jan 11, 2023
@keith keith deleted the ks/move-apple-toolchain-setup-to-apple_support branch January 11, 2023 12:59
@keith keith restored the ks/move-apple-toolchain-setup-to-apple_support branch January 12, 2023 21:20
@keith keith reopened this Jan 12, 2023
@oquenchil
Copy link
Copy Markdown
Contributor

An update on this, we will actually do it the other way around and make rules_cc the single copy instead of bazel_tools. Once I have merged all of Fabian's PRs, we can create a release.

@keith
Copy link
Copy Markdown
Member Author

keith commented Jan 13, 2023

In that case we actually want to merge this one since the single copy of this is moving to apple_support

Copy link
Copy Markdown
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keith
Copy link
Copy Markdown
Member Author

keith commented Jan 17, 2023

@oquenchil can you help land this one?

@copybara-service copybara-service bot merged commit c7849af into bazelbuild:main Jan 18, 2023
@keith keith mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants