Closed
Conversation
clang-10 is a bit old now, and envoy HEAD no longer compiles with it because of envoyproxy/envoy#23891
Member
Author
|
@meteorcloudy is it possible to run this before merging to see if it fixes https://buildkite.com/bazel/envoy/builds/2118#01849d85-5a46-4688-9dc4-2e30d6659b1b ? |
This was referenced Nov 30, 2022
Member
|
I think we should update the presubmit.yml file in the enovy repo instead: https://github.com/envoyproxy/envoy/blob/main/.bazelci/presubmit.yml#L21 This config file in the CI repo is no longer used. |
Member
|
OK, it is still used in continuous-integration/buildkite/bazelci.py Line 190 in 08f1dab |
Member
And then we can test the change before merging if you push the change to a branch in the envoy repo. |
Member
Author
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
fweikert
pushed a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-10 is a bit old now, and envoy HEAD no longer compiles with it because of envoyproxy/envoy#23891