Skip to content

only the last entry in shell_commands can fail the build #938

@mostynb

Description

@mostynb

I was testing a presubmit check for bazel-remote, and I noticed that if I have a sequence of shell_commands and one fails in the middle but the final command succeeds, then the build still succeeds. Should this instead behave like set -e in bash?

Here's my testcase:
buchgr/bazel-remote#191

I also noticed that if a shell builtin (eg exit 1) fails in presubmit.yml rather than a shell script, then the build fails as expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions