--bes_instance_name is hardcoded in CI config, but introduced only in Bazel 6, causing older Bazel versions to not work on CI #1810
Description
continuous-integration/buildkite/bazelci.py
Line 1870 in 04ac429
--bes_instance_name is hardcoded in the CI config, but it was only added for Bazel 6.x: bazelbuild/bazel@1160485#diff-392140aa68d1a6a763fcf1ad24b987f6939058f31aa50fe3ff1300f2dfb51d98
This will cause all pre-Bazel 6 CI jobs to fail with:
bazel test --flaky_test_attempts=3 --build_tests_only --local_test_jobs=12 --show_progress_rate_limit=5 --curses=yes --color=yes --terminal_columns=143 --show_timestamps --verbose_failures --jobs=30 --announce_rc --experimental_repository_cache_hardlinks --disk_cache= --sandbox_tmpfs_path=/tmp --experimental_build_event_json_file_path_conversion=false --build_event_json_file=/tmp/tmpa14qdol6/test_bep.json --google_default_credentials --remote_cache=remotebuildexecution.googleapis.com --remote_instance_name=projects/bazel-untrusted/instances/default_instance --bes_backend=buildeventservice.googleapis.com --bes_timeout=360s --bes_instance_name=bazel-untrusted --remote_timeout=60 --remote_max_connections=200 --remote_default_platform_properties=properties:{name:"cache-silo-key" value:"0aaeb93076c33223dcea5104da62537bf8f1304e2b50d3cddd99ab457dd35f50"} --remote_download_toplevel --test_env=HOME --test_env=BAZELISK_USER_AGENT --test_env=USE_BAZEL_VERSION --sandbox_writable_path=/var/lib/buildkite-agent/.cache/bazelisk -- //...
--
| /tmp/tmpa14qdol6/bazelci-agent artifact upload --delay=5 --mode=buildkite --build_event_json_file=/tmp/tmpa14qdol6/test_bep.json
| ERROR: --bes_instance_name=bazel-untrusted :: Unrecognized option: --bes_instance_name=bazel-untrusted
(from https://buildkite.com/bazel/rules-jvm-external/builds/3777#018bf66f-8dfe-457a-b741-cb67ecd197f5, bazel-contrib/rules_jvm_external#998)
Metadata
Metadata
Assignees
Labels
No labels