Skip to content

Conversation

@keith
Copy link
Member

@keith keith commented Oct 17, 2024

With bazel 8.x these should now be loaded externally. It's currently
only a soft requirement, but at this point all users should start
migrating to this.

@limdor
Copy link
Contributor

limdor commented Jan 3, 2025

It would be nice if before enabling it again, the Readme of the rules_cc is fixed.
It still says that there is no need to use rules_cc
https://github.com/bazelbuild/rules_cc?tab=readme-ov-file#getting-started
This has already being reported in rules_cc in bazelbuild/rules_cc#273

@keith keith force-pushed the ks/enable-native-rules branch from 8a55f5e to 158a320 Compare January 6, 2025 17:54
@keith
Copy link
Member Author

keith commented Jan 6, 2025

@comius can you ptal

@keith
Copy link
Member Author

keith commented Jan 6, 2025

bazelbuild/rules_cc#300

With bazel 8.x these should now be loaded externally. It's currently
only a soft requirement, but at this point all users should start
migrating to this.
@keith keith force-pushed the ks/enable-native-rules branch from 158a320 to 76c863b Compare January 6, 2025 17:57
@keith
Copy link
Member Author

keith commented Jan 6, 2025

looks like an infra error with macOS CI here

@keith
Copy link
Member Author

keith commented Jan 9, 2025

@vladmos ptal

Copy link
Member

@vladmos vladmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vladmos vladmos merged commit 04e3b5a into bazelbuild:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants