Skip to content

rules_python_gazelle_plugin@0.23.0#692

Closed
publish-to-bcr-bot[bot] wants to merge 2 commits intobazelbuild:mainfrom
f0rmiga:bazelbuild/rules_python@0.23.0-ac503ad6
Closed

rules_python_gazelle_plugin@0.23.0#692
publish-to-bcr-bot[bot] wants to merge 2 commits intobazelbuild:mainfrom
f0rmiga:bazelbuild/rules_python@0.23.0-ac503ad6

Conversation

@publish-to-bcr-bot
Copy link
Copy Markdown
Contributor

Release author: @f0rmiga.

Automated by Publish to BCR.

@rickeylev
Copy link
Copy Markdown
Contributor

Ah, I think the problem here is the test used was moved. examples/build_file_generation is workspace only; the bzlmod variant is in examples/bzlmod_build_file_generation

@rickeylev
Copy link
Copy Markdown
Contributor

I've sent bazel-contrib/rules_python#1264 to fix this at head.

@rickeylev
Copy link
Copy Markdown
Contributor

I've tagged a 0.23.1 release with the fix. I'm not sure what we should do with this PR.

  • Force merge is probably fine. It's just the test that doesn't run; the 0.23.1 release passes OK and the only change is the test path.
  • Abandon this
  • Send a PR to @f0rmiga's branch so this PR can get the fix.
  • I suggested a fix; apply that and things should be OK. I can't, but maybe a registry maintainer can.

If we abandon this, then I just need to go update the release docs to note that gazelle wasn't released with this version

Co-authored-by: Richard Levasseur <richardlev@gmail.com>
auto-merge was automatically disabled June 14, 2023 00:59

Head branch was pushed to by a user without write access

@f0rmiga
Copy link
Copy Markdown
Contributor

f0rmiga commented Jun 14, 2023

You can close this PR.

@fmeum fmeum closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants