Skip to content

Fix grpc-proto and bazel_jar_jar for Bazel 9#6856

Merged
meteorcloudy merged 2 commits intobazelbuild:mainfrom
meteorcloudy:fix_modules
Dec 16, 2025
Merged

Fix grpc-proto and bazel_jar_jar for Bazel 9#6856
meteorcloudy merged 2 commits intobazelbuild:mainfrom
meteorcloudy:fix_modules

Conversation

@meteorcloudy
Copy link
Copy Markdown
Member

@meteorcloudy meteorcloudy commented Dec 16, 2025

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Dec 16, 2025

Hello @eed3si9n, modules you maintain (bazel_jar_jar) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Dec 16, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (grpc-proto) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@meteorcloudy meteorcloudy added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels Dec 16, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the grpc-proto and bazel_jar_jar modules to ensure compatibility with Bazel 9. It introduces new patch versions (.bcr.1) for both modules, which include patches sourced from upstream to fix build issues. The necessary MODULE.bazel, presubmit.yml, and source.json files are added for the new versions, and the metadata.json files are updated accordingly. The changes appear correct and adhere to the Bazel Central Registry contribution guidelines. The presubmit configurations correctly test against Bazel 9.

@meteorcloudy meteorcloudy added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Dec 16, 2025
@meteorcloudy meteorcloudy requested a review from fmeum December 16, 2025 12:46
@meteorcloudy meteorcloudy enabled auto-merge (squash) December 16, 2025 12:48
@meteorcloudy meteorcloudy merged commit e962852 into bazelbuild:main Dec 16, 2025
18 checks passed
@meteorcloudy meteorcloudy mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeum fmeum fmeum approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meteorcloudy @bazel-io @fmeum