Skip to content

rules_python@1.7.0-rc6#6219

Merged
Wyverald merged 1 commit intobazelbuild:mainfrom
rickeylev:rules.python.1.7
Nov 13, 2025
Merged

rules_python@1.7.0-rc6#6219
Wyverald merged 1 commit intobazelbuild:mainfrom
rickeylev:rules.python.1.7

Conversation

@rickeylev
Copy link
Copy Markdown
Contributor

@rickeylev rickeylev commented Oct 16, 2025 •
edited
Loading

This is a manual BCR release of rules_python 1.7.0-rc6. Rather than continue to tag new releases with BCR-only fixes, we're doing a manual PR of just rules_python to separate from the gazelle failures and BCR-specific failures.

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Oct 16, 2025

Hello @aignas, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@rickeylev rickeylev marked this pull request as ready for review October 16, 2025 00:53
@keith keith added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 16, 2025
bazel-io
bazel-io previously approved these changes Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@rickeylev rickeylev marked this pull request as draft October 16, 2025 01:56
@rickeylev
Copy link
Copy Markdown
Contributor Author

rickeylev commented Oct 16, 2025

Hm, maybe the issue is:
It gets the archive, but uses strip_prefix=$version/gazelle
Which probably means everything outside the prefix is ignored and doesn't get extracted? If so, fix will be to have an example with the gazelle dir

@bazel-io bazel-io dismissed their stale review October 16, 2025 02:15

Require module maintainers' approval for newly pushed changes.

@rickeylev rickeylev mentioned this pull request Oct 21, 2025
Closed
@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Nov 12, 2025

Hello @aignas, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Nov 12, 2025

Hello @aignas, modules you maintain (rules_python) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Nov 12, 2025

Hello @bazelbuild/bcr-maintainers, modules with only metadata.json changes (rules_python_gazelle_plugin) have been updated in this PR.
Please review the changes.

@rickeylev rickeylev changed the title testing rules_python bcr configuration rules_python@1.7.0-rc6 Nov 12, 2025
@rickeylev rickeylev marked this pull request as ready for review November 13, 2025 02:42
@rickeylev
Copy link
Copy Markdown
Contributor Author

rickeylev commented Nov 13, 2025

@aignas -- need approver as fellow owner

@bazelbuild/bcr-maintainers -- presubmit.yaml changed, need approval

@rickeylev
Copy link
Copy Markdown
Contributor Author

rickeylev commented Nov 13, 2025

@bazel-io greetings bot may i please have this merged thank you

@bazelbuild/bcr-maintainers FYI: PR approve, but bot not merging. Need manual trigger?

@rickeylev rickeylev requested a review from bazel-io November 13, 2025 17:20
@Wyverald Wyverald merged commit 2349c33 into bazelbuild:main Nov 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeum fmeum fmeum approved these changes

@bazel-io bazel-io Awaiting requested review from bazel-io

+1 more reviewer

@aignas aignas aignas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rickeylev @bazel-io @aignas @fmeum @keith @Wyverald