Skip to content

googleapis-cc@1.0.0, googleapis-go@1.0.0, googleapis-grpc-cc@1.0.0, googleapis-grpc-java@1.0.0, googleapis-java@1.0.0, googleapis-python@1.0.0, googleapis-rules-registry@1.0.0#3786

Merged
fmeum merged 2 commits into
bazelbuild:mainfrom
fmeum:fmeum/googleapis-rules-registry@v1.0.0-81ab88a3
Feb 19, 2025
Merged

googleapis-cc@1.0.0, googleapis-go@1.0.0, googleapis-grpc-cc@1.0.0, googleapis-grpc-java@1.0.0, googleapis-java@1.0.0, googleapis-python@1.0.0, googleapis-rules-registry@1.0.0#3786
fmeum merged 2 commits into
bazelbuild:mainfrom
fmeum:fmeum/googleapis-rules-registry@v1.0.0-81ab88a3

Conversation

@publish-to-bcr-bot

@publish-to-bcr-bot publish-to-bcr-bot Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

@bazel-io

bazel-io commented Feb 13, 2025

Copy link
Copy Markdown
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (googleapis-cc, googleapis-go, googleapis-grpc-cc, googleapis-grpc-java, googleapis-java, googleapis-python, googleapis-rules-registry) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@fmeum fmeum marked this pull request as draft February 13, 2025 10:02
@bazel-io

bazel-io commented Feb 13, 2025

Copy link
Copy Markdown
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (googleapis-cc, googleapis-go, googleapis-grpc-cc, googleapis-grpc-java, googleapis-java, googleapis-python, googleapis-rules-registry, googleapis) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@fmeum fmeum changed the title googleapis-cc@1.0.0, googleapis-go@1.0.0, googleapis-grpc-cc@1.0.0, googleapis-grpc-java@1.0.0, googleapis-java@1.0.0, googleapis-python@1.0.0, googleapis-rules-registry@1.0.0 googleapis@0.0.0-20241220-5e258e33, googleapis-cc@1.0.0, googleapis-go@1.0.0, googleapis-grpc-cc@1.0.0, googleapis-grpc-java@1.0.0, googleapis-java@1.0.0, googleapis-python@1.0.0, googleapis-rules-registry@1.0.0 Feb 13, 2025
@fmeum fmeum added the skip-url-stability-check Skip the URL stability check for the PR label Feb 13, 2025
@fmeum fmeum force-pushed the fmeum/googleapis-rules-registry@v1.0.0-81ab88a3 branch from aa2890d to eafbc5c Compare February 13, 2025 10:13
@fmeum fmeum changed the title googleapis@0.0.0-20241220-5e258e33, googleapis-cc@1.0.0, googleapis-go@1.0.0, googleapis-grpc-cc@1.0.0, googleapis-grpc-java@1.0.0, googleapis-java@1.0.0, googleapis-python@1.0.0, googleapis-rules-registry@1.0.0 googleapis-cc@1.0.0, googleapis-go@1.0.0, googleapis-grpc-cc@1.0.0, googleapis-grpc-java@1.0.0, googleapis-java@1.0.0, googleapis-python@1.0.0, googleapis-rules-registry@1.0.0 Feb 13, 2025
@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 13, 2025
@fmeum fmeum force-pushed the fmeum/googleapis-rules-registry@v1.0.0-81ab88a3 branch 3 times, most recently from 6a87279 to 4852465 Compare February 13, 2025 10:26
@fmeum fmeum mentioned this pull request Feb 13, 2025
Merged
@fmeum fmeum marked this pull request as ready for review February 13, 2025 10:28
@meteorcloudy

meteorcloudy commented Feb 13, 2025

Copy link
Copy Markdown
Member

Nice work! Do we have a user-facing documentation that explains how everything work?

@fmeum

fmeum commented Feb 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Nice work! Do we have a user-facing documentation that explains how everything work?

Users don't have to interact with these modules directly. They can just start depending on googleapis and will see error messages with instructions on what to do as they start using targets. I think that's better than docs since nobody would find them anyway (we can't add them to the upstream repo).

@meteorcloudy

meteorcloudy commented Feb 13, 2025

Copy link
Copy Markdown
Member

I see, make sense!

@fmeum fmeum removed the skip-url-stability-check Skip the URL stability check for the PR label Feb 18, 2025
Wyverald
Wyverald previously approved these changes Feb 19, 2025
View reviewed changes
Comment thread modules/googleapis-cc/metadata.json Outdated
@fmeum fmeum force-pushed the fmeum/googleapis-rules-registry@v1.0.0-81ab88a3 branch from 4852465 to dda174d Compare February 19, 2025 08:15
@fmeum fmeum enabled auto-merge (squash) February 19, 2025 08:15
@bazel-io bazel-io dismissed Wyverald’s stale review February 19, 2025 08:15

Require module maintainers' approval for newly pushed changes.

@fmeum fmeum merged commit f77f5f4 into bazelbuild:main Feb 19, 2025
@fmeum fmeum deleted the fmeum/googleapis-rules-registry@v1.0.0-81ab88a3 branch February 19, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeum fmeum fmeum approved these changes

@Wyverald Wyverald Wyverald left review comments

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bazel-io @meteorcloudy @fmeum @Wyverald