Skip to content

Add explicit version minimums for macOS tools#9403

Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/version-min
Closed

Add explicit version minimums for macOS tools#9403
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/version-min

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Sep 18, 2019

This is a follow up to #9371
which helps maintain cache hits across different macOS versions. By
default when you compile something on macOS with clang the minimum OS
version is set to the current OS version. This means if you have
developers on multiple OS versions they may not get cache hits.

10.9 was chosen to match rules_apple bazelbuild/rules_apple@86ce425

This is a follow up to bazelbuild#9371
which helps maintain cache hits across different macOS versions. By
default when you compile something on macOS with clang the minimum OS
version is set to the current OS version. This means if you have
developers on multiple OS versions they may not get cache hits.
@keith
Copy link
Copy Markdown
Member Author

keith commented Sep 18, 2019

cc @DavidGoldman

@DavidGoldman DavidGoldman self-requested a review September 18, 2019 14:46
@bazel-io bazel-io closed this in 4ffb36f Sep 18, 2019
@keith keith deleted the ks/version-min branch September 18, 2019 18:19
@keith
Copy link
Copy Markdown
Member Author

keith commented Sep 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants