Make java_grpc_library work with proto_library rules using strip_import_prefix / import_prefix.#8814
Closed
Make java_grpc_library work with proto_library rules using strip_import_prefix / import_prefix.#8814
Conversation
…rt_prefix / import_prefix. In addition to this welcome functionality, this change also makes it possible to fix http://github.com/bazelbuild/bazel/issues/7157 by tolerating proto_library rules using a virtual import directory.
Contributor
Author
|
/cc @haberman |
hlopko
approved these changes
Jul 8, 2019
Member
hlopko
left a comment
There was a problem hiding this comment.
LGTM, provided you'll wait for landing of the upstream grpc change first and potentially applying their comments here as well :)
Contributor
Author
|
Do I have to? (FWIW, we have a history of just fixing this here) |
Contributor
Author
|
Merged to master in a different way. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to this welcome functionality, this change also makes it possible to fix http://github.com/bazelbuild/bazel/issues/7157 by tolerating proto_library rules using a virtual import directory.