Skip to content

add -c flag for Starlark-in-java#7683

Closed
Quarz0 wants to merge 1 commit intobazelbuild:masterfrom
Quarz0:starlark_c_flag
Closed

add -c flag for Starlark-in-java#7683
Quarz0 wants to merge 1 commit intobazelbuild:masterfrom
Quarz0:starlark_c_flag

Conversation

@Quarz0
Copy link
Copy Markdown
Contributor

@Quarz0 Quarz0 commented Mar 9, 2019

Related issues:

  • add -c flag #35
  • improve starlark-in-java installation documentation #24

Examples:
$ bazel run :Starlark -- -c "print(1)"
1
$ bazel run :Starlark -- -c "print(1)" arg3
USAGE: Starlark [-c "<cmdLineProgram>" | <fileName>]

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Quarz0
Copy link
Copy Markdown
Contributor Author

Quarz0 commented Mar 9, 2019

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 9, 2019
@aiuto aiuto requested a review from laurentlb March 13, 2019 18:13
@laurentlb laurentlb requested a review from vladmos March 13, 2019 22:38
@laurentlb
Copy link
Copy Markdown
Contributor

Thank you for implementing it.
The feature is useful. I'm currently on leave, but @vladmos may be able to review and import it.

Copy link
Copy Markdown
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I'm importing the change.

@vladmos
Copy link
Copy Markdown
Member

vladmos commented Mar 18, 2019

Sorry I haven't reviewed it, I was on leave too.

@bazel-io bazel-io closed this in 9303df6 Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants