[8.5.0] Also persist facts in the hidden lockfile#27642
Merged
iancha1992 merged 1 commit intobazelbuild:release-8.5.0from Nov 13, 2025
Merged
[8.5.0] Also persist facts in the hidden lockfile#27642iancha1992 merged 1 commit intobazelbuild:release-8.5.0from
iancha1992 merged 1 commit intobazelbuild:release-8.5.0from
Conversation
Otherwise facts are not added to the default lockfile when an entry in the hidden lockfile for a reproducible extension is used. Also bump the lockfile version out of caution - users may already have hidden lockfiles that lack facts. Along the way fix the `print` behavior of `Facts` which resulted in `Facts(<unknown object net.starlark.java.eval.Dict>)` since it called the wrong `repr` override. Closes bazelbuild#27522. PiperOrigin-RevId: 828559479 Change-Id: I77f002fa0e74c23b9fab5bb05948bcbe76f8f49b (cherry picked from commit bed7a1f)
Wyverald
approved these changes
Nov 13, 2025
Merged
via the queue into
bazelbuild:release-8.5.0
with commit Nov 13, 2025
ccb9cb8
47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise facts are not added to the default lockfile when an entry in the hidden lockfile for a reproducible extension is used.
Also bump the lockfile version out of caution - users may already have hidden lockfiles that lack facts.
Along the way fix the
printbehavior ofFactswhich resulted inFacts(<unknown object net.starlark.java.eval.Dict>)since it called the wrongreproverride.Closes #27522.
PiperOrigin-RevId: 828559479
Change-Id: I77f002fa0e74c23b9fab5bb05948bcbe76f8f49b
(cherry picked from commit bed7a1f)
Closes #27523