Revert "[8.3.0] Bazel CI: Stop building binaries on CentOS 7 (#26071)"#26366
Closed
jasonkuster wants to merge 1 commit intobazelbuild:release-8.3.0from
Closed
Revert "[8.3.0] Bazel CI: Stop building binaries on CentOS 7 (#26071)"#26366jasonkuster wants to merge 1 commit intobazelbuild:release-8.3.0from
jasonkuster wants to merge 1 commit intobazelbuild:release-8.3.0from
Conversation
…ild#26071)" This reverts commit cae0831.
Member
|
That sounds like more churn than it is worth: all major distros with glibc version < 2.25 have reached EOL, and we've already turned down the infra support for building with CentOS 7. I'll edit the 8.3.0 release notes to indicate the new minimal glibc version. |
auto-merge was automatically disabled
June 24, 2025 18:52
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit cae0831.
Moving from c7 to Rocky 8 has implicitly bumped the min glibc version needed from 2.17 to 2.25 due to the newly-in-use glibc-2.28 containing
getentropy@GLIBC_2.25. While it's overall acceptable to move versions forward, this version bump appears to have been an inadvertent and unanticipated consequence of the builder OS change and was not announced as part of the 8.3.0 release. For more discussion see the thread on the bazel slack.A reasonable approach seems to be to revert the PR temporarily, publish an 8.3.1 release without the new glibc dependency, and then re-release this change with 8.4.0 and announce that 8.4.0 bumps the minimum glibc version in the release notes for that release. Curious for thoughts.
cc @fweikert