Fix links to Protobufs on GitHub on the BEP docs page#21745
Closed
stefanobaghino wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix links to Protobufs on GitHub on the BEP docs page#21745stefanobaghino wants to merge 1 commit intobazelbuild:masterfrom
stefanobaghino wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
No, thank you for taking the time to review. 🙂 Looking forward to this being merged! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few links on this page are broken (the commit SHA for each is shortened, which apparently the GitHub UI doesn't accept). Since I was around, I thought it might have made sense to also update those pointers to a more recent version of the Protobufs in case someone uses it for reference.
The original pointers were supposed to go at the following locations
bazel/src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto
Line 91 in 16a107d
bazel/src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto
Line 123 in 16a107d
bazel/src/main/java/com/google/devtools/build/lib/buildeventstream/proto/build_event_stream.proto
Line 469 in 16a107d