Skip to content

[7.0.0] Prevent nested set flattening in ActionSpawn if there are no input filesets.#20358

Merged
meteorcloudy merged 1 commit intobazelbuild:release-7.0.0from
tjgq:flattening-cherrypick
Nov 29, 2023
Merged

[7.0.0] Prevent nested set flattening in ActionSpawn if there are no input filesets.#20358
meteorcloudy merged 1 commit intobazelbuild:release-7.0.0from
tjgq:flattening-cherrypick

Conversation

@tjgq
Copy link
Copy Markdown
Contributor

@tjgq tjgq commented Nov 29, 2023

This is always the case in Bazel. The nested set structure can be exploited to perform optimizations, notably by --experimental_remote_merkle_tree_cache.

PiperOrigin-RevId: 585657594
Change-Id: I83042b5c40b3b9e6ce511a230a0cbd0677dda5b3

…input filesets.

This is always the case in Bazel. The nested set structure can be exploited to perform optimizations, notably by --experimental_remote_merkle_tree_cache.

PiperOrigin-RevId: 585657594
Change-Id: I83042b5c40b3b9e6ce511a230a0cbd0677dda5b3
@tjgq tjgq requested a review from a team as a code owner November 29, 2023 13:59
@tjgq tjgq added this to the 7.0.0 release blockers milestone Nov 29, 2023
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions labels Nov 29, 2023
@meteorcloudy meteorcloudy enabled auto-merge (squash) November 29, 2023 14:05
@meteorcloudy meteorcloudy merged commit 91082c1 into bazelbuild:release-7.0.0 Nov 29, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 29, 2023
@tjgq tjgq deleted the flattening-cherrypick branch March 7, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants