Skip to content

Update rules_java v7.0.0 / java tools v13.0.0#19864

Closed
hvadehra wants to merge 2 commits intomasterfrom
hvd-java_tools-v13.0
Closed

Update rules_java v7.0.0 / java tools v13.0.0#19864
hvadehra wants to merge 2 commits intomasterfrom
hvd-java_tools-v13.0

Conversation

@hvadehra
Copy link
Copy Markdown
Member

@hvadehra hvadehra commented Oct 18, 2023

Release tracker: bazelbuild/java_tools#81
java_tools release: https://github.com/bazelbuild/java_tools/releases/tag/java_v13.0
rules_java release: https://github.com/bazelbuild/rules_java/releases/tag/7.0.0
BCR PR: bazelbuild/bazel-central-registry#1017
rules_java PR: bazelbuild/rules_java#144

TODO: update rules_java version to 7.0.0 once released and published to the BCR

@hvadehra hvadehra changed the title Hvd java tools v13.0 [temp/ignore] fix tests for rules_java 7.0 / java tools v13.0 Oct 18, 2023
@hvadehra hvadehra force-pushed the hvd-java_tools-v13.0 branch 13 times, most recently from 9093467 to cc78402 Compare October 18, 2023 16:31
@hvadehra hvadehra changed the title [temp/ignore] fix tests for rules_java 7.0 / java tools v13.0 Update rules_java v7.0.0 / java tools v13.0.0 Oct 18, 2023
@keertk keertk added this to the 7.0.0 release blockers milestone Oct 18, 2023
@hvadehra hvadehra force-pushed the hvd-java_tools-v13.0 branch from cc78402 to ad35543 Compare October 18, 2023 17:01
@iancha1992 iancha1992 removed this from the 7.0.0 release blockers milestone Oct 18, 2023
@iancha1992
Copy link
Copy Markdown
Member

@bazel-io fork 7.0.0

@fmeum
Copy link
Copy Markdown
Collaborator

fmeum commented Oct 18, 2023

@hvadehra I assume that this update will mostly subsume #18262? In that case I will rebase that PR onto master once this is merged, at which point it will mostly just contain tests.

Let me know if you would rather want me to update my PR to reference rules_java 7.0.0 directly.

@keertk keertk force-pushed the hvd-java_tools-v13.0 branch from ad35543 to 590d548 Compare October 19, 2023 00:37
@hvadehra
Copy link
Copy Markdown
Member Author

hvadehra commented Oct 19, 2023

Let me know if you would rather want me to update my PR to reference rules_java 7.0.0 directly.

@fmeum Yes, it's getting messy duplicating your changes just to make this work. Lets move ahead with your PR with rules_java 7.0.0

Updates all references of remote_jdk20 to remote_jdk21 as the former is removed from rules_java

 Also updates android dexer tests target to use java 8 since java 7 is no longer supported by jdk21

Update bazel_java_test integration test to match the new default java_runtime

See: bazelbuild/rules_java#132
@hvadehra hvadehra force-pushed the hvd-java_tools-v13.0 branch from 74f8caa to 579499e Compare October 19, 2023 13:12
@hvadehra
Copy link
Copy Markdown
Member Author

We're discarding this in favour of the equivalent #18262

cc @iancha1992

@hvadehra hvadehra closed this Oct 19, 2023
@hvadehra hvadehra deleted the hvd-java_tools-v13.0 branch October 19, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants