Skip to content

[6.4.0] Fetch RepoSpecs in parallel#19354

Merged
iancha1992 merged 2 commits intobazelbuild:release-6.4.0from
fmeum:cp19294-6.4.0
Aug 29, 2023
Merged

[6.4.0] Fetch RepoSpecs in parallel#19354
iancha1992 merged 2 commits intobazelbuild:release-6.4.0from
fmeum:cp19294-6.4.0

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented Aug 28, 2023

Computing RepoSpecs for all selected Bazel modules is on the critical path for the computation of the main repository mapping and thus benefits from parallelized downloads.

On my machine, this change has the following effect on bazel build //src:bazel-dev --enable_bzlmod --nobuild:

before
compute main repo mapping: 8s 127ms

after
compute main repo mapping: 4s 226ms

Closes #19294.

Commit 8a68310

PiperOrigin-RevId: 559819452
Change-Id: Ieef957fcfe402c909d2863ba4a4ca3540781a56d

@fmeum fmeum changed the base branch from master to release-6.4.0 August 28, 2023 19:22
@fmeum fmeum requested a review from a team as a code owner August 28, 2023 19:22
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Aug 28, 2023
@fmeum fmeum removed request for a team, Wyverald, brandjon, comius and tetromino August 28, 2023 19:22
Computing `RepoSpec`s for all selected Bazel modules is on the critical path for the computation of the main repository mapping and thus benefits from parallelized downloads.

On my machine, this change has the following effect on `bazel build //src:bazel-dev --enable_bzlmod --nobuild`:

```
before
compute main repo mapping: 8s 127ms

after
compute main repo mapping: 4s 226ms
```

Closes bazelbuild#19294.

PiperOrigin-RevId: 559819452
Change-Id: Ieef957fcfe402c909d2863ba4a4ca3540781a56d
@Bizocorp
Copy link
Copy Markdown

Computing RepoSpecs for all selected Bazel modules is on the critical path for the computation of the main repository mapping and thus benefits from parallelized downloads.

On my machine, this change has the following effect on bazel build //src:bazel-dev --enable_bzlmod --nobuild:

before
compute main repo mapping: 8s 127ms

after
compute main repo mapping: 4s 226ms

Closes #19294.

Commit 8a68310

PiperOrigin-RevId: 559819452
Change-Id: Ieef957fcfe402c909d2863ba4a4ca3540781a56d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants