[6.3.0] Let common ignore unsupported options#18566
Closed
iancha1992 wants to merge 1 commit intobazelbuild:release-6.3.0from
Closed
[6.3.0] Let common ignore unsupported options#18566iancha1992 wants to merge 1 commit intobazelbuild:release-6.3.0from
common ignore unsupported options#18566iancha1992 wants to merge 1 commit intobazelbuild:release-6.3.0from
Conversation
Fixes bazelbuild#3054 RELNOTES: Options specified on the pseudo-command `common` in `.rc` files are now ignored by commands that do not support them as long as they are valid options for *any* Bazel command. Previously, commands that did not support all options given for `common` would fail to run. These previous semantics of `common` are now available via the new `always` pseudo-command. Closes bazelbuild#18130. PiperOrigin-RevId: 534940403 Change-Id: I2ae268ae84de3f2b07ff3d1e36bf382bce714968
justinhorvitz
approved these changes
Jun 2, 2023
Member
Author
|
@justinhorvitz @fmeum Looks like the checks are failing. Do you think we need any additional commit to pass the checks? |
Collaborator
Contributor
|
I don't know what the Cherry-pick requirements are for 6.3 so I can't say if it qualifies. That said it's a backwards compatible change to a single flag that probably no one uses, so should be safe to apply to older code. Alternatively just adding the dep to the build file in it own commit is also probably harmless. |
Collaborator
|
@iancha1992 Could you try to cherry-pick 3dc6951 first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3054
RELNOTES: Options specified on the pseudo-command
commonin.rcfiles are now ignored by commands that do not support them as long as they are valid options for any Bazel command. Previously, commands that did not support all options given forcommonwould fail to run. These previous semantics ofcommonare now available via the newalwayspseudo-command.Closes #18130.
Commit 44d3953
PiperOrigin-RevId: 534940403
Change-Id: I2ae268ae84de3f2b07ff3d1e36bf382bce714968