Closed
Conversation
66d476b to
9ac0aec
Compare
19 tasks
Contributor
|
Just a question, but why was 9c96529 done before this was merged? |
Member
Author
|
I don't think is this a blocker for 9c96529. but this is now under review and should be merged soon anyway. |
Contributor
I disagree 😅, but I'm glad it's being merged soon! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add flag
--experimental_remote_cache_lease_extension, which when set, Bazel will create a background thread periodically sendingFindMissingBlobsrequests to CAS during the build.--experimental_remote_cache_ttl.FindMissingBlobs.FindMissingBlobsrequest per action may increase the overhead of network roundtrip, but the cost should be saturated given that the lease extension happens at background and is not wall time critical.Part of #16660.
TODO: Sending out now for early feedbacks. Unit and integration tests will be added later.