Remove macOS CLT from toolchain setup#17857
Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
Closed
Conversation
Theoretically these should be picked up by the calls above that fetch the actual include paths given the current compiler. At some point when I added this it seemed like that wasn't the case if you had both Xcode and the CLT installed, but I cannot reproduce that case to debug. This otherwise massively increased the toolchain setup time when generating the module map.
Member
Author
|
@googlewalt wdyt about this? I'm wondering if what I hit locally was a toolchain not regenerating when it went from Xcode -> CLT during development 🤔 |
Member
Author
|
obsoleted by #17763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theoretically these should be picked up by the calls above that fetch the actual include paths given the current compiler. At some point when I added this it seemed like that wasn't the case if you had both Xcode and the CLT installed, but I cannot reproduce that case to debug. This otherwise massively increased the toolchain setup time when generating the module map.
Fixes #16619 (comment)