Allow rewinding to re-create lost inputs, rebased to include RewindingTest#16470
Closed
k1nkreet wants to merge 5 commits intobazelbuild:masterfrom
Closed
Allow rewinding to re-create lost inputs, rebased to include RewindingTest#16470k1nkreet wants to merge 5 commits intobazelbuild:masterfrom
k1nkreet wants to merge 5 commits intobazelbuild:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
c745cac to
6fa3ad1
Compare
This remedies the following sequence of events: 1. Build build_tool (e.g. the go builder) from source with remote execution and `--remote_download_minimal`. 2. Use build_tool to build some_binary with remote execution. 3. Evict `build_tool` from the remote execution system. 4. Edit the sources to some_binary and attempt to build it again with remote execution. Before this change, Bazel would give an FileNotFoundException complaining that build_tool couldn't be found (and so couldn't be uploaded). After this change, Bazel will notice that it knows how to regenerate the missing file, and so rewind the graph and re-perform the actions it needs to be able to build some_binary. Co-authored-by: Ilya Polyakovskiy <polyakovskiy.ilya@gmail.com>
c019af0 to
929e2c6
Compare
passing graphInconsistencyReceiver to SkyframeExecutor from WorkspaceBuilder
a101efa to
225c56b
Compare
a56b8b1 to
7d6c15e
Compare
Collaborator
Member
|
As Benjamin pointed out, we are open sourcing more action rewinding code. I don't know where we are landing to, but this PR is now outdated. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is #14126 rebased on HEAD to include
RewindingTest.javawhich was opensourced recently and introduce some limitations for #14126