WIP: Track runfiles library users in RunfilesProvider#16126
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
WIP: Track runfiles library users in RunfilesProvider#16126fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
This was referenced Aug 18, 2022
546b2cd to
b1b435e
Compare
RunfilesProvider now tracks the repository names and mappings of runfiles library users among the transitive non-tool dependencies of each rule, as marked by the RunfilesLibraryInfo provider. The list of runfiles library users for an executable target will be used in a follow-up commit to create a repository mapping manifest containing only the mappings of those repositories that contain targets that actually perform runfiles lookups.
b1b435e to
b0e835e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunfilesProvider now tracks the repository names and mappings of
runfiles library users among the transitive non-tool dependencies of
each rule, as marked by the RunfilesLibraryInfo provider.
The list of runfiles library users for an executable target will be used
in a follow-up commit to create a repository mapping manifest containing
only the mappings of those repositories that contain targets that
actually perform runfiles lookups.
Work towards #16124