Fix an issue that `incompatible_remote_build_event_upload_respect_no_…#16045
Merged
sgowroji merged 2 commits intobazelbuild:release-5.3.0from Aug 4, 2022
Merged
Fix an issue that `incompatible_remote_build_event_upload_respect_no_…#16045sgowroji merged 2 commits intobazelbuild:release-5.3.0from
sgowroji merged 2 commits intobazelbuild:release-5.3.0from
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cache` doesn't work with BwtB.
The root cause is we use
Pathas key to check which files are omitted, but it also compares the underlying filesystem. When BwtB is enabled, the filesystem for the file is different so we failed to mark the file as omitted.This change fixes that by using
PathFragmentas key.Fixes #15527.
Closes #16023.
PiperOrigin-RevId: 465284879
Change-Id: I49bbd7a6055e0f234b4ac86a224886bd85797f71