Add factory for creating paths relative to well-known roots#15931
Merged
sgowroji merged 2 commits intobazelbuild:release-5.3.0from Jul 20, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a factory for creating
PathFragmentsrelative topre-defined (named) roots (e.g., relative to
%workspace%).The syntax is choosen to match existing ad-hoc solutions for
%workspace%,or
%builtins%in other places (so that we can ideally migrate them ina follow-up).
We'll use this for parsing paths from the command-line (e.g.,
--credential_helper=%workspace%/foo).Progress on https://github.com/bazelbuild/proposals/blob/main/designs/2022-06-07-bazel-credential-helpers.md
Closes #15805.
PiperOrigin-RevId: 460950483
Change-Id: Ie263fb6d6c2ea938a850a72793d551135df6862e