Rewind on --remote_download_minimal upload FileNotFounds#15345
Closed
illicitonion wants to merge 1 commit intobazelbuild:masterfrom
Closed
Rewind on --remote_download_minimal upload FileNotFounds#15345illicitonion wants to merge 1 commit intobazelbuild:masterfrom
illicitonion wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Currently, when building with `--remote_download_minimal`, if the remote storage has evicted an output of a previous action, Bazel will throw a FileNotFoundException for it. This change detects that scenario, and re-throws it as a LostInputsExecException, tracking enough metadata on the way to do so. If rewinding is enabled for a build, this will cause rewinding to automatically kick in.
Contributor
Author
|
/cc @justinhorvitz |
Contributor
|
Friendly ping on this @ericfelly. |
Member
|
Closing as we are moving forward with lease service. #16660 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when building with
--remote_download_minimal, if the remotestorage has evicted an output of a previous action, Bazel will throw a
FileNotFoundException for it.
This change detects that scenario, and re-throws it as a
LostInputsExecException, tracking enough metadata on the way to do so.
If rewinding is enabled for a build, this will cause rewinding to
automatically kick in.