Remote: Cleanup the code that determines whether the spawn should accept/upload results from/to remote cache.#13769
Closed
coeuvre wants to merge 6 commits intobazelbuild:masterfrom
Closed
Remote: Cleanup the code that determines whether the spawn should accept/upload results from/to remote cache.#13769coeuvre wants to merge 6 commits intobazelbuild:masterfrom
coeuvre wants to merge 6 commits intobazelbuild:masterfrom
Conversation
philwo
approved these changes
Jul 30, 2021
| public boolean mayBeCached(Spawn spawn) { | ||
| return remoteCache != null && Spawns.mayBeCached(spawn); | ||
| private static boolean useDiskCache(RemoteOptions options) { | ||
| return options.diskCache != null && !options.diskCache.isEmpty(); |
Member
There was a problem hiding this comment.
Can we use !isNullOrEmpty(options.diskCache) here?
Member
Author
There was a problem hiding this comment.
options.diskCache is a PathFragment, before converting to String we have to check for null, which makes isNullOrEmpty less appealing.
…ept/upload results from/to remote cache.
…e of a combined cache for no-remote-cache spawns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote cache (and execution) for an action can be controlled with following tags:
no-remote-cache: prevent remote caching, but allow local cachingno-remote-exec: prevent remote execution, but allow remote cachingno-remote: combine no-remote-cache and no-remote-execno-cache: extend no-remote-cache to also prevent local cachingA combined cache is treated as remote cache, hence is disabled for actions that are tagged with
no-remote-cacheunless--incompatible_remote_results_ignore_diskis set in which case local component is enabled.Fixes #13621.