Support building 32-bit C++ binaries on Windows with MSVC toolchain#11938
Support building 32-bit C++ binaries on Windows with MSVC toolchain#11938mai12 wants to merge 9 commits into
Conversation
Adding support for compiling 32-bit binaries.
|
Thanks for working on this! A few suggestions first:
|
meteorcloudy
left a comment
There was a problem hiding this comment.
This is real nice implementation! Thanks!
Can you add the test? 😃
|
Another /MACHINE:X64 is hard coded in windows_cc_toolchain_config.bzl, you probably need to refactor it as an attribute like the default_link_flags, otherwise the build will fail with:
|
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@mai12 It looks like you committed with a different account? Can you switch back to the same account? |
This reverts commit 0b69021.
|
I think you can do a force push to override the commits pushed by another account? |
|
@googlebot I fixed it. |
1 similar comment
|
@googlebot I fixed it. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR will allow Bazel to compile 32-bit c++ build targets on windows. A new cc toolchain (
cc-compiler-x64_x86_windows) is added to support compiling 32-bit c++ binaries using MSVC compiler.To use this toolchain, the
--cpuoption in the build command needs to be set tox64_x86_windows.Fixes: #10963
@meteorcloudy