-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Closed
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)incompatible-changeIncompatible/breaking changeIncompatible/breaking changeteam-Rules-ServerIssues for serverside rules included with BazelIssues for serverside rules included with Bazeltype: process
Milestone
Description
//tools/build_defs/pkg:{pkg_deb, pkg_rpm, pkg_tar} are being pulled out of Bazel core and moved to https://github.com/bazelbuild/rules_pkg/tree/master/pkg. Users should migrate to the new versions.
Migration:
-
Add WORKSPACE stanza as specified in a rule_pkg release
https://github.com/bazelbuild/rules_pkg/releases -
Replace instances of
load("//tools/build_defs/pkg:pkg.bzl", "pkg_tar", "pkg_deb") load("//tools/build_defs/pkg:rpm.bzl", "pkg_rpm")with
load("@rules_pkg//:pkg.bzl", "pkg_tar", "pkg_deb") load("@rules_pkg//:rpm.bzl", "pkg_rpm")One line solution (for some users)
find . -name 'BUILD' -o -name '*.bzl' | xargs sed -i -e '/^load/s#//tools/build_defs/pkg:#@rules_pkg//:#'
Expected timeline:
- The bazelbuild/rules_pkg repository is available for use now. Issues against packaging rules are being transferred to that repository and will be addressed there.
- Flag to be released in Bazel 0.29.
- Enabled by default in next Bazel incompatible flag flip release after 0.29
- //tools/build_defs/pkg/... removed from Bazel by EOY 2019
Metadata
Metadata
Assignees
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)incompatible-changeIncompatible/breaking changeIncompatible/breaking changeteam-Rules-ServerIssues for serverside rules included with BazelIssues for serverside rules included with Bazeltype: process