-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Closed
Labels
P1I'll work on this now. (Assignee required)I'll work on this now. (Assignee required)incompatible-changeIncompatible/breaking changeIncompatible/breaking change
Description
When a bzl file contains a load, e.g.
load("//some:file.bzl", "fct")
it implicitly exports fct.
This is problematic for many reasons:
- Exports should be explicit
- Other languages don't do that
- Removing a load can break other files
- So it means we can't have a tool to safely remove unused loads
Unfortunately, this is a breaking change.
There are two ways to fix it.
- Update the load site and use the label of the file where the symbol is really declared
- Update the loaded file. To explicitly re-export the symbol
foo, use:
load("...", _foo = "foo")
foo = _fooReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P1I'll work on this now. (Assignee required)I'll work on this now. (Assignee required)incompatible-changeIncompatible/breaking changeIncompatible/breaking change