-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Use git hash as hashing function #12158
Copy link
Copy link
Closed as not planned
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)staleIssues or PRs that are stale (no activity for 30 days)Issues or PRs that are stale (no activity for 30 days)team-CoreSkyframe, bazel query, BEP, options parsing, bazelrcSkyframe, bazel query, BEP, options parsing, bazelrcteam-Remote-ExecIssues and PRs for the Execution (Remote) teamIssues and PRs for the Execution (Remote) teamtype: feature request
Description
Original title: No evaluation of inode equality in FileContentsProxy
Description of the problem / feature request:
No evaluation of inode equality in
FileContentsProxy.
Feature requests: what underlying problem are you trying to solve with this feature?
Speed up analysis phase by not adding whole worskspace to second level digest check. (described here).
What operating system are you running Bazel on?
Ubuntu 18.04/20.04.
What's the output of bazel info release?
release 2.2.0
Any other information, logs, or outputs that you want to share?
We are compiling a large repo (several MLoC) and the analysis phase takes 1-2 minutes.
We are using several layers of caching, including bazel remote cache. To reduce the traffic to the remote cache, we are also reusing.cache/bazelintermediate files across runs (baked into a node image deployed onto VMs).
Since the inodes of files after a git pull and checkout are not the same across runs, analysis phase takes very long, since files are effectively rehashed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)staleIssues or PRs that are stale (no activity for 30 days)Issues or PRs that are stale (no activity for 30 days)team-CoreSkyframe, bazel query, BEP, options parsing, bazelrcSkyframe, bazel query, BEP, options parsing, bazelrcteam-Remote-ExecIssues and PRs for the Execution (Remote) teamIssues and PRs for the Execution (Remote) teamtype: feature request