Turn applicable_licenses on platform() into a no-op. (#18089)

aiuto · web-flow · commit 5ddef4716e33 · 2023-04-13T13:40:36.000-07:00
This prevents an analysis loop where default_applicable_licenses
applies a license to a platform, but then the same license rule
depends on the platform.

Backport of Ic12306f5a405c88bd65acf3b8ec419328ce663f3
diff --git a/src/main/java/com/google/devtools/build/lib/rules/platform/PlatformBaseRule.java b/src/main/java/com/google/devtools/build/lib/rules/platform/PlatformBaseRule.java
@@ -21,6 +21,7 @@
 import com.google.devtools.build.lib.analysis.PlatformConfiguration;
 import com.google.devtools.build.lib.analysis.RuleDefinition;
 import com.google.devtools.build.lib.analysis.RuleDefinitionEnvironment;
+import com.google.devtools.build.lib.packages.BuildType;
 import com.google.devtools.build.lib.packages.RuleClass;
 import com.google.devtools.build.lib.packages.RuleClass.ToolchainResolutionMode;
 import com.google.devtools.build.lib.packages.Type;
@@ -41,6 +42,13 @@ public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env)
                 // No need to show up in ":all", etc. target patterns.
                 .value(ImmutableList.of("manual"))
                 .nonconfigurable("low-level attribute, used in platform configuration"))
+        .override(
+            // A platform is essentially a constant which is never linked into a target.
+            // This will, in a very hacky way, suppress picking up default_applicable_licenses
+            attr("applicable_licenses", BuildType.LABEL_LIST)
+                .value(ImmutableList.of())
+                .allowedFileTypes()
+                .nonconfigurable("fundamental constant, used in platform configuration"))
         .exemptFromConstraintChecking("this rule helps *define* a constraint")
         .useToolchainResolution(ToolchainResolutionMode.DISABLED)
         .removeAttribute("deps")
