Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/apple_support
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.22.0
Choose a base ref
...
head repository: bazelbuild/apple_support
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.22.1
Choose a head ref
  • 8 commits
  • 18 files changed
  • 5 contributors

Commits on May 18, 2025

  1. Upstream: add sdk attribute to xcode_version (#406)

    Upstreams:
    
    -
    ed48510
    -
    7400308
    luispadron authored May 18, 2025
    Configuration menu
    Copy the full SHA
    bbedb16 View commit details
    Browse the repository at this point in the history
  2. Upstream: Define xcode_support.get_current_sdk and `xcode_support.g…

    …et_current_xcode` helpers (#408)
    luispadron authored May 18, 2025
    Configuration menu
    Copy the full SHA
    766340e View commit details
    Browse the repository at this point in the history

Commits on May 20, 2025

  1. Upstream: Add an optional argument to allow users of the apple_suppor…

    …t methods to resolve constraints to return None rather than fail when a constraint is not found. (#410)
    
    Upstreams:
    07f7876
    luispadron authored May 20, 2025
    Configuration menu
    Copy the full SHA
    9b4497c View commit details
    Browse the repository at this point in the history
  2. Upstream: remove xcode_config_alias (#409)

    Upstreams:
    436b03d
    
    ---------
    
    Co-authored-by: Tony Allevato <allevato@google.com>
    luispadron and allevato authored May 20, 2025
    Configuration menu
    Copy the full SHA
    b72a95c View commit details
    Browse the repository at this point in the history

Commits on May 27, 2025

  1. Upstream: Add an "empty SDK" variant. (#412)

    This will be used as the `//conditions:default` choice for the
    `xcode_version.sdk` attribute, ensuring that non-configured
    builds/queries don't fail early if they just happen to graze one of the
    Xcode targets.
    
    PiperOrigin-RevId: 726034982
    
    And:
    
    PiperOrigin-RevId: 725333279
    
    ---------
    
    Co-authored-by: Tony Allevato <allevato@google.com>
    luispadron and allevato authored May 27, 2025
    Configuration menu
    Copy the full SHA
    d348852 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2025

  1. use DefaultInfo in apple_support (#413)

    We here address the following obstacles in `apple_support` to using
    Bazel's
    `--incompatible_disable_target_default_provider_fields` flag:
    
    ERROR:
    /private/var/tmp/_bazel_dws/7fd3cd5077fbf76d9e2ae421c39ef7ed/external/apple_support+/crosstool/BUILD:25:20:
    in apple_genrule rule
    @@apple_support+//crosstool:exec_wrapped_clang_pp.target_config:
        Traceback (most recent call last):
    File
    "/private/var/tmp/_bazel_dws/7fd3cd5077fbf76d9e2ae421c39ef7ed/external/apple_support+/rules/private/apple_genrule.bzl",
    line 52, column 45, in _apple_genrule_impl
    resolved_srcs = depset(transitive = [dep.files for dep in
    ctx.attr.srcs])
    Error: Accessing the default provider in this manner is deprecated and
    will be removed soon. It may be temporarily re-enabled by setting
    --incompatible_disable_target_default_provider_fields=false. See
    bazelbuild/bazel#20183 for details.
    ERROR:
    /private/var/tmp/_bazel_dws/7fd3cd5077fbf76d9e2ae421c39ef7ed/external/apple_support+/crosstool/BUILD:25:20:
    Analysis of target
    '@@apple_support+//crosstool:exec_wrapped_clang_pp.target_config' failed
    ERROR: Analysis of target '//src:bazel' failed; build aborted: Analysis
    failed
    
    ERROR:
    /private/var/tmp/_bazel_dws/7fd3cd5077fbf76d9e2ae421c39ef7ed/external/apple_support++apple_cc_configure_extension+local_config_apple_cc/BUILD:78:24:
    in cc_toolchain_config rule
    @@apple_support++apple_cc_configure_extension+local_config_apple_cc//:darwin_x86_64:
        Traceback (most recent call last):
    File
    "/private/var/tmp/_bazel_dws/7fd3cd5077fbf76d9e2ae421c39ef7ed/external/apple_support++apple_cc_configure_extension+local_config_apple_cc/cc_toolchain_config.bzl",
    line 2506, column 37, in _impl
                        modulemaps = ctx.attr.module_map.files.to_list()
    Error: Accessing the default provider in this manner is deprecated and
    will be removed soon. It may be temporarily re-enabled by setting
    --incompatible_disable_target_default_provider_fields=false. See
    bazelbuild/bazel#20183 for details.
    ERROR:
    /private/var/tmp/_bazel_dws/7fd3cd5077fbf76d9e2ae421c39ef7ed/external/apple_support++apple_cc_configure_extension+local_config_apple_cc/BUILD:78:24:
    Analysis of target
    '@@apple_support++apple_cc_configure_extension+local_config_apple_cc//:darwin_x86_64'
    failed
    ERROR: Analysis of target '//src:bazel' failed; build aborted: Analysis
    failed
    dws authored Jun 11, 2025
    Configuration menu
    Copy the full SHA
    8dbccb3 View commit details
    Browse the repository at this point in the history
  2. Fix more cases of DefaultInfo use (#414)

    Required for compatibility with
    bazelbuild/bazel#20183
    keith authored Jun 11, 2025
    Configuration menu
    Copy the full SHA
    da96f62 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2025

  1. Consume the pipes before waiting for pid (#411)

    In general one shouldn't call waitpid until the child closed its end of
    the pipe. This works fine with libtool invocations that do not produce
    more than `_PC_PIPE_BUF` bytes of output but deadlocks when the pipe
    fills up.
    Reflejo authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    19cbebf View commit details
    Browse the repository at this point in the history
Loading