Skip to content

[Bazel6] Remove --experimental_worker_allow_json_protocol#615

Merged
mattrobmattrob merged 1 commit intobazel-ios:masterfrom
mattrobmattrob:mr/remove.experimental_worker_allow_json_protocol
Nov 28, 2022
Merged

[Bazel6] Remove --experimental_worker_allow_json_protocol#615
mattrobmattrob merged 1 commit intobazel-ios:masterfrom
mattrobmattrob:mr/remove.experimental_worker_allow_json_protocol

Conversation

@mattrobmattrob
Copy link
Copy Markdown
Collaborator

@mattrobmattrob mattrobmattrob commented Nov 28, 2022

Handle bazelbuild/bazel#14679 to prepare for Bazel 6.0.0.

Port bazelbuild/bazel#14679 into `rules_ios` to prepare for Bazel 6.0.0.
@mattrobmattrob
Copy link
Copy Markdown
Collaborator Author

Let me know if you all know there's a reason to leave this around. Seems like it was added as a default ability much before removal.

@mattrobmattrob mattrobmattrob marked this pull request as ready for review November 28, 2022 18:59
Copy link
Copy Markdown
Contributor

@jerrymarino jerrymarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattrobmattrob LGTM - I was curious if this actually had a functional impact prior to 6.0 / surprised it didn't break 5.3.2

@jerrymarino
Copy link
Copy Markdown
Contributor

jerrymarino commented Nov 28, 2022

Edit: according to the linked thread - the related fix was likely cherry-picked onto 5.x.x at some point

@mattrobmattrob mattrobmattrob merged commit 1c8b244 into bazel-ios:master Nov 28, 2022
@mattrobmattrob mattrobmattrob deleted the mr/remove.experimental_worker_allow_json_protocol branch November 28, 2022 20:11
@mattrobmattrob mattrobmattrob changed the title Remove --experimental_worker_allow_json_protocol [Bazel6] Remove --experimental_worker_allow_json_protocol Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants