Add module-root option for changing module location within the repository#69
Merged
p0deje merged 2 commits intobazel-contrib:mainfrom Feb 21, 2025
calebzulawski:main
Merged
Add module-root option for changing module location within the repository#69p0deje merged 2 commits intobazel-contrib:mainfrom calebzulawski:main
p0deje merged 2 commits intobazel-contrib:mainfrom
calebzulawski:main
Conversation
Contributor
Author
|
The last iteration of |
Member
|
Does it work on your projects? |
Contributor
Author
|
Yep, it appears to work for me. I get a bazelisk cache key now |
Member
|
Does the disk cache work fine as well? |
Contributor
Author
|
It appears to work to the extent that the hashes are correct... I think I might be running into another issue: Lines 70 to 72 in 9824807 If the BUILD files are all the same, but something in the sources or workflow changes, doesn't this prevent the updated disk cache from being saved? |
p0deje
approved these changes
Feb 21, 2025
Member
Yes, it prevents uploading - the disk cache is not stored incrementally. See #18 for a discussion on this topic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67