Include repository cache files in the disk cache key.#64
Merged
p0deje merged 2 commits intobazel-contrib:mainfrom Jan 24, 2025
bmclarnon:disk-cache
Merged
Include repository cache files in the disk cache key.#64p0deje merged 2 commits intobazel-contrib:mainfrom bmclarnon:disk-cache
p0deje merged 2 commits intobazel-contrib:mainfrom
bmclarnon:disk-cache
Conversation
Like BUILD file changes, changes to workspace dependencies can significantly affect the contents of the disk cache. Prior to this change, upreving dependencies wasn't itself sufficient to update the disk cache, resulting in repeatedly rebuilding dependencies until some subsequent commit happened to modify BUILD files.
Contributor
Author
|
I was planning to squash the commits when merging. If this repo doesn't support squashing and you'd prefer that the PR only contains a single commit, please let me know. Thanks! |
Member
|
Thank you! |
Contributor
Author
|
Thank you for such a quick review -- and for maintaining this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like BUILD file changes, changes to workspace dependencies can significantly affect the contents of the disk cache. Prior to this change, upreving dependencies wasn't itself sufficient to update the disk cache, resulting in repeatedly rebuilding dependencies until some subsequent commit happened to modify BUILD files.
One of my projects has a dependency that take several hours to build; I recently realized that the reason that all builds were taking several hours is that we hadn't modified any BUILD files since upreving that dependency. Hopefully this prevents other people from having similar issues!