fix: Add post-if !cancelled() condition#128
Merged
p0deje merged 1 commit intobazel-contrib:mainfrom Jan 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a post-if condition to prevent the post-cleanup action from running when a workflow is cancelled. This addresses issue #121 and aligns with the repository's CI configuration which uses cancel-in-progress: true.
Key Changes:
- Adds
post-if: "!cancelled()"condition to action.yml to skip cache saving when workflows are cancelled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p0deje
approved these changes
Jan 8, 2026
Member
|
@vorburger You can point your CI configuration to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #121.
I have NOT tested that this actually works! Mostly because I'm not entirely sure how I would really test it... change the action in my project to use my fork, and cancel the build to see if this does the trick? Could do, but... @p0deje do you think there is any risk to just adding this without really testing it?