pip_parse and pip_install can now parse entry points from wheels#523
Merged
alexeagle merged 12 commits intobazel-contrib:mainfrom Sep 5, 2021
UebelAndre:entrypoint
Merged
pip_parse and pip_install can now parse entry points from wheels#523alexeagle merged 12 commits intobazel-contrib:mainfrom UebelAndre:entrypoint
pip_parse and pip_install can now parse entry points from wheels#523alexeagle merged 12 commits intobazel-contrib:mainfrom
UebelAndre:entrypoint
Conversation
alexeagle
reviewed
Sep 5, 2021
Contributor
|
This is awesome! thanks, I'll merge and go patch into a client codebase and see if we can remove some of our wrappers. I bet the working directory issue will still be a problem, but that's a missing feature in |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, there is no way to access binaries (or entry points) associated with a wheel in python. This has been a rather annoying problem since it expects users to manually generate it themselves. A process for which there's currently there's no guidance on. This PR aims to solve that by generating these targets automatically.
Issue Number: #341
What is the new behavior?
Both pip_install and pip_parse now generate
py_binarytargets for each entry point in a wheel. These are accessible via theentry_pointmacro which has been added to therequirements.bzlfiles generated by these repository rules.To use this new functionality, you simply load the
entry_pointmacro:Then. the target can be run just like any other
py_binary.Does this PR introduce a breaking change?
Other information