Added targets for data and dist-info to pip generated targets#519
Merged
alexeagle merged 1 commit intobazel-contrib:mainfrom Aug 31, 2021
UebelAndre:wheel
Merged
Added targets for data and dist-info to pip generated targets#519alexeagle merged 1 commit intobazel-contrib:mainfrom UebelAndre:wheel
alexeagle merged 1 commit intobazel-contrib:mainfrom
UebelAndre:wheel
Conversation
alexeagle
approved these changes
Aug 31, 2021
Contributor
alexeagle
left a comment
There was a problem hiding this comment.
Thanks!
I wish there was a test for this, if you have some time could you add one in a followup? I'm not sure where to look for one (maybe the examples/pip_install could do something with the dist_info or data from boto3?)
Contributor
Author
Yeah, I can put together a test when I have a block of free time |
13 tasks
Contributor
Author
|
I've opened #524 to add tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
A wheel is documented to contain both
.dist-infoand.datadirectories which contain additional metadata for a particular package. However, even though the pip repository rules extract wheel contents into the repository directory, data in these directories are not exposed. In order to access this, the:whltarget must be consumed and unzipped again, even though this information already lives in the pip repository generated by Bazel. Something should be done to expose this data so users don't have to write additional parsers.Issue Number: N/A
What is the new behavior?
This pull request exposes files in
.dataand.dist-infoin individual filegroups, allowing users to consume them without having to re-extract this data from the wheel.Does this PR introduce a breaking change?
Other information