Escape characters in the wheel filename.#518
Merged
alexeagle merged 2 commits intobazel-contrib:mainfrom Aug 31, 2021
pstradomski:master
Merged
Escape characters in the wheel filename.#518alexeagle merged 2 commits intobazel-contrib:mainfrom pstradomski:master
alexeagle merged 2 commits intobazel-contrib:mainfrom
pstradomski:master
Conversation
Contributor
|
Thanks! What's the implication of the wrong handling for unicode alpha characters? Is that frequent? |
Contributor
Author
|
I've never encountered a distribution that would use non-ascii symbols.
wt., 31 sie 2021 o 05:26 Alex Eagle ***@***.***> napisał(a):
… Thanks!
What's the implication of the wrong handling for unicode alpha characters?
Is that frequent?
IIUC that's not a newly introduced regression in this PR, as those wheels
would have had wrong names before as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#518 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKU4J4L7AGC7LQ3O6WNPWCTT7RDXFANCNFSM5DAR5PSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Paweł Stradomski
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape characters in the wheel filename.
Note the implementation is buggy, it replaces non-ascii (unicode) letters in the filename. Unfortunately, starlark isalnum function returns wrong result here, and regexp support is not available yet.
Fixes #517.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #517
What is the new behavior?
Does this PR introduce a breaking change?
Other information