pip_parse: Fix when using a python wrapper script#505
Merged
alexeagle merged 2 commits intobazel-contrib:mainfrom Sep 12, 2021
Merged
pip_parse: Fix when using a python wrapper script#505alexeagle merged 2 commits intobazel-contrib:mainfrom
alexeagle merged 2 commits intobazel-contrib:mainfrom
Conversation
8ef3863 to
b318e1c
Compare
hrfuller
reviewed
Aug 10, 2021
| ) | ||
| parser.add_argument( | ||
| "--python_interpreter_target", | ||
| help="Bazel target of the python interpreter. It will take precedence over python_interpreter.", |
Contributor
There was a problem hiding this comment.
Some documentation explaining that this has to be a reference to another external repository would be helpful. To me the name implies that this could be a reference to a target in the current workspace, which wouldn't work unless it was a prebuilt binary.
Contributor
Author
There was a problem hiding this comment.
That's right thanks, outside of the .bzl this becomes much less obvious, I've updated the documentation. I've not changed the name of the argument to keep it consistent with whl_library/pip_parse though. (sorry for the slow reaction, I was away from computers!).
|
@hrfuller :bump: this changes looks mergeable 👍 |
117d0bf to
0586582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
When using
pip_parsewith a python wrapper script inpython_interpreterorpython_interpreter_target, the declaredwhl_librarydo not use the wrapper script but directly the underlying python interpreter given bysys.executable.We use a portable python distribution that needs some environment adaptation in the
PATHandLD_LIBRARY_PRELOADvariables to run properly. Calling directly the python interpreter binary fails, sopip_parseitself is successful but the wheels cannot be retrieved.What is the new behavior?
pip_parsenow transmitspython_interpreterandpython_interpreter_targetattributes to thewhl_librarytargetswhl_librarynow takespython_interpreter_targetin accountDoes this PR introduce a breaking change?
Other information