Skip to content

Terminology update 'master' to 'main' in DEVELOPING.md#502

Merged
thundergolfer merged 2 commits intomainfrom
jonathon--master-to-main-jul2021
Jul 8, 2021
Merged

Terminology update 'master' to 'main' in DEVELOPING.md#502
thundergolfer merged 2 commits intomainfrom
jonathon--master-to-main-jul2021

Conversation

@thundergolfer
Copy link
Copy Markdown

@thundergolfer thundergolfer commented Jul 4, 2021

Change directly related to #500

As far as I can see these are the only relevant master refs in the codebase.


PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@thundergolfer thundergolfer requested a review from andyscott as a code owner July 4, 2021 09:40
@google-cla google-cla bot added the cla: yes label Jul 4, 2021
@thundergolfer thundergolfer requested review from alexeagle and hrfuller and removed request for andyscott July 4, 2021 09:41
@thundergolfer
Copy link
Copy Markdown
Author

Requesting @hrfuller as I think Alex may be on vacation.

@thundergolfer
Copy link
Copy Markdown
Author

:bump: @hrfuller

Merging this should also trigger CI and we can check it's compatible with our new main branch setup.

@thundergolfer thundergolfer merged commit 736b7ef into main Jul 8, 2021
@thundergolfer thundergolfer deleted the jonathon--master-to-main-jul2021 branch July 8, 2021 23:46
@thundergolfer
Copy link
Copy Markdown
Author

@philwo our scheduled builds are failing due the main rename. What do we have to update to fix this?

@alexeagle
Copy link
Copy Markdown
Contributor

@fweikert has an open PR for this already on bazelbuild/continuous-integration repo

@thundergolfer
Copy link
Copy Markdown
Author

@philwo
Copy link
Copy Markdown
Contributor

philwo commented Jul 9, 2021

Should be working again now!

I fixed the "Default branch" setting in Buildkite:
image

And the branch of the "Scheduled builds":
Screen Shot 2021-07-09 at 11 22 31

@thundergolfer
Copy link
Copy Markdown
Author

@philwo Thanks mate 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants