Skip to content

Ensure pip_compile_requirements' py_binary target can recieve 'tags'#496

Merged
alexeagle merged 1 commit intomasterfrom
jonathon--pass-tags-properly-in-compile_pip_requirements-jun2021
Jun 23, 2021
Merged

Ensure pip_compile_requirements' py_binary target can recieve 'tags'#496
alexeagle merged 1 commit intomasterfrom
jonathon--pass-tags-properly-in-compile_pip_requirements-jun2021

Conversation

@thundergolfer
Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The py_test target created by compile_pip_requirements can receive tags via **kwargs but the py_binary target (.update) cannot.

What is the new behavior?

Both targets created by the compile_pip_requirements macro can receive tags.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@thundergolfer thundergolfer requested review from alexeagle and removed request for brandjon and lberki June 23, 2021 08:10
@alexeagle alexeagle merged commit e887347 into master Jun 23, 2021
@thundergolfer thundergolfer deleted the jonathon--pass-tags-properly-in-compile_pip_requirements-jun2021 branch June 24, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants