Conversation
thundergolfer
commented
Jun 23, 2021
| default, `pip_install` uses the system command `"python3"`. This can be overridden by passing the | ||
| `python_interpreter` attribute or `python_interpreter_target` attribute to `pip_install`. | ||
|
|
||
| You can have multiple `pip_install`s in the same workspace, e.g. for Python 2 |
Author
There was a problem hiding this comment.
This was never true and shouldn't have been in docs. Python 2 couldn't be used with pip_install, it only ever supported Python 3.5+ I think.
thundergolfer
commented
Jun 23, 2021
| load("@rules_python//python/legacy_pip_import:pip.bzl", "pip_import", "pip_repositories") | ||
|
|
||
| # Create a central repo that knows about the dependencies needed for requirements.txt. | ||
| pip_import( # or pip3_import |
Author
There was a problem hiding this comment.
Let's not even encourage Python 3 usage with pip_import, because I don't want to field maintenance questions about it.
hrfuller
approved these changes
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?