Make lazily fetching dependencies compatible to disallow_empty_glob#477
Merged
hrfuller merged 2 commits intobazel-contrib:masterfrom Jun 9, 2021
martis42:make_lazily_fetching_compatible_to_disallow_empty_glob
Merged
Make lazily fetching dependencies compatible to disallow_empty_glob#477hrfuller merged 2 commits intobazel-contrib:masterfrom martis42:make_lazily_fetching_compatible_to_disallow_empty_glob
hrfuller merged 2 commits intobazel-contrib:masterfrom
martis42:make_lazily_fetching_compatible_to_disallow_empty_glob
Conversation
Some python packages are provided as ".tar.gz" instead of ".whl". In such cases globbing for ".whl" files returns an empty result.
thundergolfer
approved these changes
Jun 9, 2021
thundergolfer
left a comment
There was a problem hiding this comment.
LGTM but also requesting @hrfuller as pip_parse owner.
hrfuller
approved these changes
Jun 9, 2021
| filegroup( | ||
| name="{whl_file_label}", | ||
| srcs=glob(["*.whl"]), | ||
| srcs=glob(["*.whl"], allow_empty = True), |
Contributor
There was a problem hiding this comment.
Seems okay to me. It could be strange for consumers of the raw wheel files to get less wheels than are in their requirements_lock.txt but I suppose someone who only wants to resolve wheels can pass `--binary-only=":all:"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some python packages are provided as
.tar.gzinstead of.whl.In such cases globbing for ".whl" files returns an empty result.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #476
What is the new behavior?
The behavior described in the issue is resolved and thus fetching dependencies lazily while using
--incompatible_disallow_empty_globbecomes possible.Does this PR introduce a breaking change?
Other information