Allow overriding CUSTOM_COMPILE_COMMAND#472
Merged
thundergolfer merged 1 commit intobazel-contrib:masterfrom May 17, 2021
Merged
Allow overriding CUSTOM_COMPILE_COMMAND#472thundergolfer merged 1 commit intobazel-contrib:masterfrom
thundergolfer merged 1 commit intobazel-contrib:masterfrom
Conversation
This way if users have bazel wrappers the error message can be correct
thundergolfer
approved these changes
May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way if users have bazel wrappers the error message can be correct
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the output recommendation is always
bazel run TARGETIssue Number: N/A
What is the new behavior?
If users add
env = {"CUSTOM_COMPILE_COMMAND": "foo"}the output recommendation will befooDoes this PR introduce a breaking change?
Other information
We might prefer an attribute over an env var override here, happy to go down either path