Skip to content

Allow overriding CUSTOM_COMPILE_COMMAND#472

Merged
thundergolfer merged 1 commit intobazel-contrib:masterfrom
keith:ks/allow-overriding-custom_compile_command
May 17, 2021
Merged

Allow overriding CUSTOM_COMPILE_COMMAND#472
thundergolfer merged 1 commit intobazel-contrib:masterfrom
keith:ks/allow-overriding-custom_compile_command

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented May 13, 2021

This way if users have bazel wrappers the error message can be correct

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently the output recommendation is always bazel run TARGET

Issue Number: N/A

What is the new behavior?

If users add env = {"CUSTOM_COMPILE_COMMAND": "foo"} the output recommendation will be foo

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

We might prefer an attribute over an env var override here, happy to go down either path

This way if users have bazel wrappers the error message can be correct
@keith keith requested review from brandjon and lberki as code owners May 13, 2021 19:12
@google-cla google-cla bot added the cla: yes label May 13, 2021
@thundergolfer thundergolfer requested a review from alexeagle May 14, 2021 01:31
@thundergolfer thundergolfer merged commit ed6cc8f into bazel-contrib:master May 17, 2021
@keith keith deleted the ks/allow-overriding-custom_compile_command branch May 17, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants