Remove leading ./ in compile_pip_requirements#471
Merged
alexeagle merged 1 commit intobazel-contrib:masterfrom May 12, 2021
Merged
Remove leading ./ in compile_pip_requirements#471alexeagle merged 1 commit intobazel-contrib:masterfrom
alexeagle merged 1 commit intobazel-contrib:masterfrom
Conversation
Contributor
Author
|
Ping @alexeagle since I can't request you for review. |
alexeagle
approved these changes
May 12, 2021
keith
reviewed
May 12, 2021
| sys.exit(1) | ||
|
|
||
| requirements_in = sys.argv.pop(1) | ||
| requirements_in = os.path.relpath(sys.argv.pop(1)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
The
compile_pip_requirementsrule will list the requirements as coming from./requirements.in.Issue Number: closes #470
What is the new behavior?
It will be attributed to
requirements.in, which lets it work out-of-the-box with tools like dependabot.Does this PR introduce a breaking change?
Other information
None