@hrfuller a polite ping (don't have permission to request you as a reviewer).

I believe this would cause a regression to #427 in pip_parse. I think the correct way to do this is probably to extract the wheels into a subdirectory instead of at the root of the individual repos.

I believe this would cause a regression to #427 in pip_parse

Hasn’t the regression already happened? An empty BUILD file is already present when using pip_parse.

Ah, or maybe “this” -> “the current state of affairs” and not “the changes in this PR”, in which case yes I think so.

My concern is that excluding "BUILD" would exclude a valid build directory on case insensitive file systems. There wont be a regression ala #427 because we write build file contents into BUILD.bazel now. Bazel "glob" ignores directories by default so if you tried to install the keyring wheel used as example in $427 the build directory would be excluded.

As an aside if you need an immediate workaround you can use the pip_data_excludes

As I mention above, I think the correct way to fix this issue is to create the wheel package in a sub directory.

There wont be a regression ala #427 because we write build file contents into BUILD.bazel now

Right, but when using pip_parse there is also an autogenerated BUILD file in the directory too (which is what I was trying to convey in #440). i.e. right now there is both BUILD.bazel and BUILD in the generated repos, which should already cause the regression.

Certainly this PR isn't the right fix, and I'm happy to close it-but I believe the regression is already present. Using a sub-directory would be another work around-but at the end of the day this appears to be a Bazel bug-it seems to be adding an automatic empty BUILD file even when a BUILD.bazel file is already present.

A concrete example of the regression (rules_python is at master):

$ cat keyring_requirements.txt
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile keyring_requirements.in
#
keyring==22.3.0
    # via -r keyring_requirements.in
$ cat WORKSPACE
local_repository(
    name = "rules_python",
    path = "../rules_python",
)

load("@rules_python//python:pip.bzl", "pip_parse")

pip_parse(
    name = "keyring",
    requirements_lock = "//:keyring_requirements.txt",
)

load("@keyring//:requirements.bzl", "install_deps")
install_deps()
$ bazelisk build @keyring_pypi__keyring//...
[snip]
NotADirectoryError: [Errno 20] Not a directory: 'build/lib'
)
INFO: Elapsed time: 2.335s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

Ah, I was mistaken; it's not a Bazel thing; looks like it's this line that inserts the empty build file:

https://github.com/bazelbuild/rules_python/blob/master/python/pip_install/pip_repository.bzl#L15

I'll open a new PR with the proper fix...

#457 should be a better fix.