Removes Ubuntu 16.04 (and Python 3.5) support from CI#417
Merged
thundergolfer merged 7 commits intobazel-contrib:masterfrom Mar 30, 2021
Merged
Removes Ubuntu 16.04 (and Python 3.5) support from CI#417thundergolfer merged 7 commits intobazel-contrib:masterfrom
thundergolfer merged 7 commits intobazel-contrib:masterfrom
Conversation
This was referenced Mar 1, 2021
Collaborator
Author
|
Any feedback or indication on this one? Python 3.5 is EOL as of 6 months ago: https://endoflife.date/python |
Contributor
|
I think this is a good idea. Without python 3.5 in CI we can use f-strings in our python code, which is a nice hygiene improvement. |
hrfuller
approved these changes
Mar 16, 2021
Collaborator
Author
|
Ping @andyscott @thundergolfer Would be great to unblock #412 |
|
Think the README should get some language about the Python versions we aim to support. That information is either missing or wrong (eg. Python 2 not supported by packaging rules). https://endoflife.date/python is a good start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Removes Ubuntu 16.04 (and Python 3.5) support from CI
Does this PR introduce a breaking change?
Other information
This will unblock the upgrade of pip 21.0.1 in this PR #412